Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use client/v2 v2.0.0-beta3; fix broken client.toml usage (backport #3210) #3224

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 22, 2024

Fixes a bug discovered during testing.

The CLI would ignore the variables from client.toml which forced operators to always use --node <IP:port> command line options.

The fix consists of changing root.go cmd wiring and updating cosmossdk.io/client/v2 v2.0.0-beta3. The application does not use depinject.

Related:

* fix: use client/v2 v2.0.0-beta3; fix broken client.toml usage

* Update root.go

(cherry picked from commit 27da5e8)
@mergify mergify bot requested a review from zmanian as a code owner July 22, 2024 08:52
@mergify mergify bot requested review from crodriguezvega, jackzampolin and a team as code owners July 22, 2024 08:52
@MSalopek MSalopek merged commit 56e6831 into release/v19.x Jul 22, 2024
11 of 13 checks passed
@MSalopek MSalopek deleted the mergify/bp/release/v19.x/pr-3210 branch July 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant